Support response header filter for GRPCRoute#1983
Merged
Merged
Conversation
github-actions
Bot
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
+ Coverage 86.90% 86.92% +0.01%
==========================================
Files 88 88
Lines 6056 6064 +8
Branches 50 50
==========================================
+ Hits 5263 5271 +8
Misses 741 741
Partials 52 52 ☔ View full report in Codecov by Sentry. |
ciarams87
force-pushed
the
feat/grpc-response-header-filter
branch
from
7afe38a to
66bd9f7
Compare
sjberman
approved these changes
May 16, 2024
Contributor
|
👍 |
ciarams87
force-pushed
the
feat/grpc-response-header-filter
branch
from
66bd9f7 to
f0e75dc
Compare
ciarams87
force-pushed
the
feat/grpc-response-header-filter
branch
from
f0e75dc to
556c8c7
Compare
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As a user, I want to be able to add ResponseHeaderModifier filter for my GRPCRoutes.
Solution: Add support for ResponseHeaderModifier filter for my GRPCRoutes. The implementation reuses validation and logic from the HTTPRoute implementation. This PR also removes some redundant empty structs in the servers_test.go
Testing: The functionality is identical to HTTPRoute so not much additional testing is required. I tested locally using echo server and grpcurl. I didn't modify the application to configure headers on the upstream side, but we can see the response headers set in the GRPCRoute spec have been returned:
Closes #1935
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.